Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756532AbYGMVEb (ORCPT ); Sun, 13 Jul 2008 17:04:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755040AbYGMVEX (ORCPT ); Sun, 13 Jul 2008 17:04:23 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:50794 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752909AbYGMVEW (ORCPT ); Sun, 13 Jul 2008 17:04:22 -0400 Date: Sun, 13 Jul 2008 14:03:52 -0700 From: Andrew Morton To: Dmitry Cc: linux-kernel@vger.kernel.org, "Haavard Skinnemoen" , "Russell King" , "Paul Mundt" , "pHilipp Zabel" , "Pavel Machek" , tony@atomide.com, paul@pwsan.com, "David Brownell" , "Mark Brown" , ian Subject: Re: [PATCH 1/3] genclk: add generic framework for managing clocks. Message-Id: <20080713140352.5d81614c.akpm@linux-foundation.org> In-Reply-To: References: <20080708134242.GA6176@doriath.ww600.siemens.net> <20080708134336.GA6240@doriath.ww600.siemens.net> <20080712234823.e632c7f9.akpm@linux-foundation.org> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 629 Lines: 17 On Mon, 14 Jul 2008 00:53:51 +0400 Dmitry wrote: > > > + list_del(&clk->priv.node); > > > + kref_put(&clk->priv.ref, clk_release); > > > > > > Might not be able to call kref_put(), either. > > I'll move it outside of the spinlock. But tell me please, why? Because the release handler might not like being called under that lock. I didn't check... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/