Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756000AbYGMV4U (ORCPT ); Sun, 13 Jul 2008 17:56:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754124AbYGMV4H (ORCPT ); Sun, 13 Jul 2008 17:56:07 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:45499 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753949AbYGMV4F (ORCPT ); Sun, 13 Jul 2008 17:56:05 -0400 Date: Sun, 13 Jul 2008 14:55:25 -0700 From: Andrew Morton To: Krzysztof Halasa Cc: , netdev@vger.kernel.org, Stephen Hemminger , "David S. Miller" , Russell King Subject: Re: [bisected] kernel panic 2.6.22 -> 2.6.26-rc9+ Message-Id: <20080713145525.51a1ca3a.akpm@linux-foundation.org> In-Reply-To: References: <20080713013107.23f060f2.akpm@linux-foundation.org> <20080713112230.e86ba9ae.akpm@linux-foundation.org> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1292 Lines: 39 On Sun, 13 Jul 2008 23:51:06 +0200 Krzysztof Halasa wrote: > Andrew Morton writes: > > > --- a/include/asm-arm/bitops.h~a > > +++ a/include/asm-arm/bitops.h > > @@ -277,9 +277,16 @@ static inline int constant_fls(int x) > > * the clz instruction for much better code efficiency. > > */ > > > > -#define fls(x) \ > > +#define __fls(x) \ > > ( __builtin_constant_p(x) ? constant_fls(x) : \ > > ({ int __r; asm("clz\t%0, %1" : "=r"(__r) : "r"(x) : "cc"); 32-__r; }) ) > > + > > +/* Implement fls() in C so that 64-bit args are suitably truncated */ > > +static inline int fls(int x) > > +{ > > + return __fls(x); > > +} > > + > > Well, I like it more as it fixes all possible places instead of only > fls64(). > > But... can't we just move the #define body into the inline fls(x)? > Will there be other users of __fls(x)? It seems the > __builtin_constant_p(x) works for inline functions. Could. That was a minimal&safe thing. > The above patch fixes the kernel panic, too. OK, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/