Subject: Re: [PATCH 1/1] LCD backlight driver using Atmel PWM driver
From: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <20080711121752.56db3d83.akpm@linux-foundation.org>
References: <1215608886-26792-1-git-send-email-hans-christian.egtvedt@atmel.com>
	 <20080711121752.56db3d83.akpm@linux-foundation.org>
Content-Type: text/plain
Date: Mon, 14 Jul 2008 09:11:02 +0200
Message-Id: <1216019462.7672.6.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1110
Lines: 32

On Fri, 2008-07-11 at 12:17 -0700, Andrew Morton wrote:
> On Wed,  9 Jul 2008 15:08:06 +0200 Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> wrote:
> 
> > +	if (bd->props.power != FB_BLANK_UNBLANK)
> > +		intensity = 0;
> > +	if (bd->props.fb_blank != FB_BLANK_UNBLANK)
> > +		intensity = 0;
> 
> hm, is that correct?  It is strange that two different fields can validly
> be compared with the same enumeration like this.
> 

I also found it a bit weird having two fields indicating the same, but
the header file has the following documentation:

/* Current FB Power mode (0: full on, 1..3: power saving
   modes; 4: full off), see FB_BLANK_XXX */
int power;
/* FB Blanking active? (values as for power) */
int fb_blank;

So, AFAIK, my assumptions are correct to get proper blanking?

-- 
With kind regards,
Hans-Christian Egtvedt, Applications Engineer

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/