Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754757AbYGNMjK (ORCPT ); Mon, 14 Jul 2008 08:39:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753273AbYGNMix (ORCPT ); Mon, 14 Jul 2008 08:38:53 -0400 Received: from casper.infradead.org ([85.118.1.10]:56590 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752800AbYGNMiw (ORCPT ); Mon, 14 Jul 2008 08:38:52 -0400 Subject: Re: [PATCH] qla1280: use request_firmware From: Jaswinder Singh To: Jes Sorensen Cc: LKML , David Woodhouse , Alan Cox , kernel-janitors , kernelnewbies , linux-scsi@vger.kernel.org, hch@infradead.org In-Reply-To: <487B1C73.5000202@sgi.com> References: <1215770284.2733.10.camel@jaswinder.satnam> <487B1C73.5000202@sgi.com> Content-Type: text/plain Date: Mon, 14 Jul 2008 18:08:08 +0530 Message-Id: <1216039088.10198.8.camel@jaswinder.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 920 Lines: 34 Hello Jes, On Mon, 2008-07-14 at 11:29 +0200, Jes Sorensen wrote: > Jaswinder Singh wrote: > > this is a first draft; please be kind :) > > > > Firmware blob is little endian looks like this... > > unsigned char Version1 > > unsigned char Version2 > > unsigned char Version3 > > unsigned char Padding > > unsigned short start_address > > unsigned short data > > Hello, > > As the maintainer of this driver I am going to say that I think this is > a stupid change. We have not changed the data. We are passing risc_code01 data by using request_firmware when required. If you found some problem in the code, Please let me know. Thank you, Jaswinder Singh. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/