Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756937AbYGNP5o (ORCPT ); Mon, 14 Jul 2008 11:57:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753857AbYGNP5f (ORCPT ); Mon, 14 Jul 2008 11:57:35 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:34346 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753386AbYGNP5e (ORCPT ); Mon, 14 Jul 2008 11:57:34 -0400 Date: Mon, 14 Jul 2008 11:57:33 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Johannes Berg cc: Linus Torvalds , "Rafael J. Wysocki" , Linux Kernel Mailing List , Adrian Bunk , Andrew Morton , Natalie Protasevich , Kernel Testers List , Greg KH Subject: Re: 2.6.26-rc9-git12: Reported regressions from 2.6.25 In-Reply-To: <1216044398.23746.10.camel@johannes.berg> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1590 Lines: 41 On Mon, 14 Jul 2008, Johannes Berg wrote: > > > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11072 > > > > Subject : scsi-layer crash after usb storage device unplug > > > > Submitter : Johannes Berg > > > > Date : 2008-07-12 01:50 (2 days old) > > > > Handled-By : Alan Stern > > > > Patch : http://bugzilla.kernel.org/show_bug.cgi?id=11072#c3 > > > > > > Alan, Greg? > > > > We haven't heard back yet from Johannes to confirm that the fix really > > works. If it does, IMO the patch should go into 2.6.26.1. > > > > (In fact it might not be so easy to tell, since the failure is caused > > be a race. Perhaps it would be best to submit the patch in any case.) > > I haven't had a chance to apply the patch, but given that to cause the > oops to happen I had to unplug/replug the device at random intervals for > probably 10 minutes (yes, it took me that long to figure out I had put > an SDHC card into an SD reader) I suppose it really won't be easy to > tell. Add printk(KERN_ALERT "Unplug now!\n"); ssleep(10); to the start of slave_configure() in drivers/usb/storage/scsiglue.c. Then it should be very easy to trigger the failure. :-) Assuming the failure does occur without the patch, see if it still occurs once the patch is in place. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/