Date: Mon, 14 Jul 2008 13:43:45 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Michael Buesch <mb@bu3sch.de>
Cc: sfr@canb.auug.org.au, linux-kernel@vger.kernel.org, david-b@pacbell.net,
       piotr.skamruk@gmail.com, openwrt-devel@lists.openwrt.org
Subject: Re: [PATCH] Add SPI over GPIO driver
Message-Id: <20080714134345.a2287c6c.akpm@linux-foundation.org>
In-Reply-To: <200807142109.13243.mb@bu3sch.de>
References: <200807142109.13243.mb@bu3sch.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 864
Lines: 25

On Mon, 14 Jul 2008 21:09:12 +0200
Michael Buesch <mb@bu3sch.de> wrote:

> +static inline void do_spidelay(struct spi_device *dev, unsigned nsecs)
> +{
> +	struct spi_gpio *sp = spidev_to_sg(dev);
> +
> +	if (!sp->info->no_spi_delay)
> +		ndelay(nsecs);
> +}
> +
> +#define spidelay(nsecs) do {					\
> +	/* Steal the spi_device pointer from our caller.	\
> +	 * The bitbang-API should probably get fixed here... */	\
> +	do_spidelay(spi, nsecs);				\
> +  } while (0)

A macro which requires that its caller have a particular local variable
is a bit nasty.  Could we plan to add the spi_device* to spidelay()
please? 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/