DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org;
	h=Received:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id:X-Identified-User:DomainKey-Status;
	b=SMpl0QXKD7jQppPJOaSNnWmFchv+Dn+H8g0pPxtg2Kyg+ZZPonjXKxz0ykIvf50Vh7ubGRLofinhBKmkgDAiWNj7uV7+Aoi56eqN3d9WdJHzPnAZtSkYdSPxI9b7SJa3;
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] Fix pci_subsys_init() to have a return value
Date: Mon, 14 Jul 2008 14:21:03 -0700
User-Agent: KMail/1.9.9
Cc: akpm@linux-foundation.org, linux-pci@vger.kernel.org,
       linux-kernel@vger.kernel.org
References: <20080711094636.18199.94804.stgit@warthog.procyon.org.uk>
In-Reply-To: <20080711094636.18199.94804.stgit@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200807141421.03305.jbarnes@virtuousgeek.org>
DomainKey-Status: no signature
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1125
Lines: 34

On Friday, July 11, 2008 2:46 am David Howells wrote:
> Fix pci_subsys_init() to return a value (0) when it has finished.  All the
> functions it calls currently return 0, so returning 0 here unconditionally
> rather than gathering the results of its callees would seem reasonable.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
>
>  arch/x86/pci/legacy.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> diff --git a/arch/x86/pci/legacy.c b/arch/x86/pci/legacy.c
> index 3c1d795..00e29c8 100644
> --- a/arch/x86/pci/legacy.c
> +++ b/arch/x86/pci/legacy.c
> @@ -63,5 +63,6 @@ int __init pci_subsys_init(void)
>  	pci_legacy_init();
>  	pcibios_irq_init();
>  	pcibios_init();
> +	return 0;
>  }
>  subsys_initcall(pci_subsys_init);

Looks like Robert already pushed a patch like this via the x86 tree, but at 
least it's been fixed.

Thanks,
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/