Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755352AbYGOFUI (ORCPT ); Tue, 15 Jul 2008 01:20:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752183AbYGOFT5 (ORCPT ); Tue, 15 Jul 2008 01:19:57 -0400 Received: from gate.crashing.org ([63.228.1.57]:34749 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752030AbYGOFT4 (ORCPT ); Tue, 15 Jul 2008 01:19:56 -0400 Subject: Re: [GIT *] Allow request_firmware() to be satisfied from in-kernel, use it in more drivers. From: Benjamin Herrenschmidt Reply-To: benh@kernel.crashing.org To: David Woodhouse Cc: Linus Torvalds , david@lang.hm, Arjan van de Ven , Andrew Morton , alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org In-Reply-To: <1216082640.27455.116.camel@shinybook.infradead.org> References: <1216077806.27455.85.camel@shinybook.infradead.org> <20080714164119.99c33d5b.akpm@linux-foundation.org> <20080714165956.7fe2d4ee@infradead.org> <1216082213.27455.109.camel@shinybook.infradead.org> <1216082640.27455.116.camel@shinybook.infradead.org> Content-Type: text/plain Date: Tue, 15 Jul 2008 15:05:07 +1000 Message-Id: <1216098307.7740.54.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1124 Lines: 30 On Mon, 2008-07-14 at 17:44 -0700, David Woodhouse wrote: > On Mon, 2008-07-14 at 17:40 -0700, Linus Torvalds wrote: > > > > On Mon, 14 Jul 2008, David Woodhouse wrote: > > > > > > I see no real point in that. If you have userspace to load modules, then > > > you have userspace to load firmware. > > > > David, the case is different: the module is loaded _across_ the > > suspend/resume, but the device needs to have its firmware reloaded at > > resume time because it lost power. > > Either I put my reply in response to the wrong quotation, or you thought > I did. > > I intended the above to be a response to the "please put firmware _into_ > the .ko file" request. Not to the suspend/resume thing. > > Yes, I agree that suspend/resume is a non-issue. Besides, request_firmware() from a resume() method is broken. Has always been and will probably always be. Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/