Subject: Re: [PATCH] Add SPI over GPIO driver
From: Ben Nizette <bn@niasdigital.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Stephen Rothwell <sfr@canb.auug.org.au>,
       linux-kernel <linux-kernel@vger.kernel.org>,
       David Brownell <david-b@pacbell.net>,
       Piot Skamruk <piotr.skamruk@gmail.com>, openwrt-devel@lists.openwrt.org
In-Reply-To: <200807142109.13243.mb@bu3sch.de>
References: <200807142109.13243.mb@bu3sch.de>
Content-Type: text/plain
Organization: Nias Digital
Date: Tue, 15 Jul 2008 15:30:51 +1000
Message-Id: <1216099851.4265.156.camel@moss.renham>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1087
Lines: 28


On Mon, 2008-07-14 at 21:09 +0200, Michael Buesch wrote:
> This adds a driver that lets you drive an SPI bus over
> generic GPIO pins.

Right, this is where spi-gpio is, please disregard my question in the
mmc-spi-gpio thing thread, it was domestic blindness after all :-)

Looks good overall.  I'm not sure that it need pretend to be
hotpluggable though (i.e. the board info can be hardwired so there's no
need for the board setup callback).  I guess this is to integrate with
your "dynamically create an mmc over spi over gpio" thinggy in the other
thread.  As I said there, I'd prefer that this platform device is
treated like other platform devices and any dynamicness be introduced at
in a more generic way.

What problem are you solving (or whole in board support are you
plugging) in this dynamic plugging of MMCs?

Thanks,
	--Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/