Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756734AbYGOMIn (ORCPT ); Tue, 15 Jul 2008 08:08:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752950AbYGOMId (ORCPT ); Tue, 15 Jul 2008 08:08:33 -0400 Received: from sovereign.computergmbh.de ([85.214.69.204]:52942 "EHLO sovereign.computergmbh.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752947AbYGOMId (ORCPT ); Tue, 15 Jul 2008 08:08:33 -0400 Date: Tue, 15 Jul 2008 14:08:31 +0200 (CEST) From: Jan Engelhardt To: Patrick McHardy cc: David Howells , akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix netfilter xt_time's time_mt()'s use of do_div() In-Reply-To: <487C8D60.9040405@trash.net> Message-ID: References: <20080711140206.982.19421.stgit@warthog.procyon.org.uk> <487C8D60.9040405@trash.net> User-Agent: Alpine 1.10 (LNX 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 18 On Tuesday 2008-07-15 13:43, Patrick McHardy wrote: > David Howells wrote: >> Fix netfilter xt_time's time_mt()'s use of do_div() on an s64 by using >> div_s64() instead. >> >> This was introduced by patch ee4411a1b1e0b679c99686629b5eab5a072ce49f. > > Alternatively we could use an u64 for the time. Jan, any preferences? ktime_t and ktime_to_ns operate on signed quantities. I do not think we should be interpreting it as unsigned. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/