Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757539AbYGOMKz (ORCPT ); Tue, 15 Jul 2008 08:10:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755281AbYGOMKo (ORCPT ); Tue, 15 Jul 2008 08:10:44 -0400 Received: from stinky.trash.net ([213.144.137.162]:55855 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755009AbYGOMKn (ORCPT ); Tue, 15 Jul 2008 08:10:43 -0400 Message-ID: <487C93C1.4030305@trash.net> Date: Tue, 15 Jul 2008 14:10:41 +0200 From: Patrick McHardy User-Agent: Mozilla-Thunderbird 2.0.0.12 (X11/20080405) MIME-Version: 1.0 To: Jan Engelhardt CC: David Howells , akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix netfilter xt_time's time_mt()'s use of do_div() References: <20080711140206.982.19421.stgit@warthog.procyon.org.uk> <487C8D60.9040405@trash.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 20 Jan Engelhardt wrote: > On Tuesday 2008-07-15 13:43, Patrick McHardy wrote: > >> David Howells wrote: >>> Fix netfilter xt_time's time_mt()'s use of do_div() on an s64 by using >>> div_s64() instead. >>> >>> This was introduced by patch ee4411a1b1e0b679c99686629b5eab5a072ce49f. >> Alternatively we could use an u64 for the time. Jan, any preferences? > > ktime_t and ktime_to_ns operate on signed quantities. I do not think we > should be interpreting it as unsigned. OK, I've applied David's patch. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/