From: Michael Buesch <mb@bu3sch.de>
To: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Add SPI over GPIO driver
Date: Tue, 15 Jul 2008 14:52:13 +0200
User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405)
Cc: sfr@canb.auug.org.au, linux-kernel@vger.kernel.org, david-b@pacbell.net,
       piotr.skamruk@gmail.com, openwrt-devel@lists.openwrt.org
References: <200807142109.13243.mb@bu3sch.de> <20080714134345.a2287c6c.akpm@linux-foundation.org>
In-Reply-To: <20080714134345.a2287c6c.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200807151452.13573.mb@bu3sch.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1121
Lines: 34

On Monday 14 July 2008 22:43:45 Andrew Morton wrote:
> On Mon, 14 Jul 2008 21:09:12 +0200
> Michael Buesch <mb@bu3sch.de> wrote:
> 
> > +static inline void do_spidelay(struct spi_device *dev, unsigned nsecs)
> > +{
> > +	struct spi_gpio *sp = spidev_to_sg(dev);
> > +
> > +	if (!sp->info->no_spi_delay)
> > +		ndelay(nsecs);
> > +}
> > +
> > +#define spidelay(nsecs) do {					\
> > +	/* Steal the spi_device pointer from our caller.	\
> > +	 * The bitbang-API should probably get fixed here... */	\
> > +	do_spidelay(spi, nsecs);				\
> > +  } while (0)
> 
> A macro which requires that its caller have a particular local variable
> is a bit nasty.  Could we plan to add the spi_device* to spidelay()
> please? 


Yeah right. I was planning to fix this later on _after_ this was merged.
This makes the merge easier with less patch cross-dependencies.


-- 
Greetings Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/