Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756921AbYGOOlR (ORCPT ); Tue, 15 Jul 2008 10:41:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751692AbYGOOlF (ORCPT ); Tue, 15 Jul 2008 10:41:05 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:43122 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118AbYGOOlE (ORCPT ); Tue, 15 Jul 2008 10:41:04 -0400 Subject: Re: [GIT *] Allow request_firmware() to be satisfied from in-kernel, use it in more drivers. From: David Woodhouse To: Oliver Neukum Cc: david@lang.hm, Arjan van de Ven , David Miller , torvalds@linux-foundation.org, rene.herman@keyaccess.nl, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org In-Reply-To: <200807150823.35628.oliver@neukum.org> References: <487C0A12.9060906@keyaccess.nl> <1216101795.27455.213.camel@shinybook.infradead.org> <200807150823.35628.oliver@neukum.org> Content-Type: text/plain Date: Tue, 15 Jul 2008 07:40:54 -0700 Message-Id: <1216132854.27455.247.camel@shinybook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1226 Lines: 29 On Tue, 2008-07-15 at 08:23 +0200, Oliver Neukum wrote: > Am Dienstag 15 Juli 2008 08:03:15 schrieb David Woodhouse: > > Mostly it follows the documented recommendation, since most of the > > touched drivers are USB drivers and you end up re-enumerating and > > starting from scratch on resume anyway. And the remainder are so old > > that they don't have suspend/resume support anyway. Remember, we're only > > really updating the older drivers; newer drivers tend to use > > request_firmware() already, and have done for years. > > As for USB that was before persistance. It now allows you to even > support a loss of power without reprobing, provided > > a) the devices does not change IDs > b) you have firmware around when reset_resume() is called c) the driver in question actually _has_ a reset_resume() method The old, unloved drivers which I've touched as part of this patch set did not. In general the newer, loved drivers use request_firmware() already. -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/