Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756602AbYGOO6W (ORCPT ); Tue, 15 Jul 2008 10:58:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752722AbYGOO6F (ORCPT ); Tue, 15 Jul 2008 10:58:05 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:34533 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752989AbYGOO6E (ORCPT ); Tue, 15 Jul 2008 10:58:04 -0400 Subject: Re: [PATCH] x86: Introducing asm-x86/syscalls.h From: David Woodhouse To: Jaswinder Singh Cc: LKML , Linus Torvalds , Alan Cox , kernelnewbies , kernel-janitors In-Reply-To: <1216127174.30096.3.camel@jaswinder.satnam> References: <1216114072.21749.1.camel@jaswinder.satnam> <1216127174.30096.3.camel@jaswinder.satnam> Content-Type: text/plain Date: Tue, 15 Jul 2008 07:58:03 -0700 Message-Id: <1216133883.27455.252.camel@shinybook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1354 Lines: 40 On Tue, 2008-07-15 at 18:36 +0530, Jaswinder Singh wrote: > Updated Patch: > > declaring arch-dependent syscalls for x86 under one hood Thanks Jaswinder, this looks quite sensible in general and should go some way towards making sparse shut up about undeclared functions. You should Cc Ingo though. I don't like this bit though: > --- a/include/linux/syscalls.h > +++ b/include/linux/syscalls.h > @@ -65,6 +65,10 @@ struct getcpu_cache; > #include > #include > > +#ifdef CONFIG_X86 > +#include > +#endif > + > asmlinkage long sys_time(time_t __user *tloc); > asmlinkage long sys_stime(time_t __user *tptr); > asmlinkage long sys_gettimeofday(struct timeval __user *tv, We're going to want to do this for all architectures, aren't we? Perhaps it's better to provide for all architectures from the beginning, and not bother with the ifdef? Or if you must have an ifdef, perhaps make it on something like ARCH_HAS_ASM_SYSCALLS_H rather than having to change it every time an architecture adds its own file? -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/