Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760108AbYGOQAf (ORCPT ); Tue, 15 Jul 2008 12:00:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753522AbYGOQA1 (ORCPT ); Tue, 15 Jul 2008 12:00:27 -0400 Received: from casper.infradead.org ([85.118.1.10]:50301 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754912AbYGOQA0 (ORCPT ); Tue, 15 Jul 2008 12:00:26 -0400 Subject: Re: [PATCH] x86: Introducing asm-x86/syscalls.h From: Jaswinder Singh To: David Woodhouse Cc: LKML , Linus Torvalds , Alan Cox , kernelnewbies , kernel-janitors , Ingo Molnar In-Reply-To: <1216133883.27455.252.camel@shinybook.infradead.org> References: <1216114072.21749.1.camel@jaswinder.satnam> <1216127174.30096.3.camel@jaswinder.satnam> <1216133883.27455.252.camel@shinybook.infradead.org> Content-Type: text/plain Date: Tue, 15 Jul 2008 21:29:38 +0530 Message-Id: <1216137578.2747.16.camel@jaswinder.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1257 Lines: 39 Hello David, On Tue, 2008-07-15 at 07:58 -0700, David Woodhouse wrote: > I don't like this bit though: > > > --- a/include/linux/syscalls.h > > +++ b/include/linux/syscalls.h > > @@ -65,6 +65,10 @@ struct getcpu_cache; > > #include > > #include > > > > +#ifdef CONFIG_X86 > > +#include > > +#endif > > + > > asmlinkage long sys_time(time_t __user *tloc); > > asmlinkage long sys_stime(time_t __user *tptr); > > asmlinkage long sys_gettimeofday(struct timeval __user *tv, > > We're going to want to do this for all architectures, aren't we? Perhaps > it's better to provide for all architectures from the > beginning, and not bother with the ifdef? Or if you must have an ifdef, > perhaps make it on something like ARCH_HAS_ASM_SYSCALLS_H rather than > having to change it every time an architecture adds its own > file? > OK, I will also create asm/syscalls.h for all the architectures. Thank you, Jaswinder Singh. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/