Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758003AbYGORRQ (ORCPT ); Tue, 15 Jul 2008 13:17:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752981AbYGORRA (ORCPT ); Tue, 15 Jul 2008 13:17:00 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:53576 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752157AbYGORQ7 (ORCPT ); Tue, 15 Jul 2008 13:16:59 -0400 Message-ID: <487CDB85.3050208@garzik.org> Date: Tue, 15 Jul 2008 13:16:53 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Linus Torvalds CC: David Woodhouse , Arjan van de Ven , Andrew Morton , alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org Subject: Re: [GIT *] Allow request_firmware() to be satisfied from in-kernel, use it in more drivers. References: <1216077806.27455.85.camel@shinybook.infradead.org> <20080714164119.99c33d5b.akpm@linux-foundation.org> <20080714165956.7fe2d4ee@infradead.org> <487C0365.5030203@garzik.org> <487C09EB.1050903@garzik.org> <487C1648.5070409@garzik.org> <487C500F.8000109@garzik.org> <1216107418.27455.236.camel@shinybook.infradead.org> <487C5ABE.2010907@garzik.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1248 Lines: 41 Linus Torvalds wrote: > I call bullshit. You don't like the change - ok. SIGH. Wrong, wrong, wrong. I have always thought request_firmware() was a good idea, even if it decreased reliability. Because we need that ability and that API. The changes are good, They just don't need to break stuff. Which they do. > But stop making bogus > arguments about it. How many more real world examples of breakage do you need? * This breaks newer kernel / older userland * This breaks anywhere with a file list for modules' contents (ipkg kernel module packages) * This breaks driver disk build packages * This breaks for the oddball, not just me, who * This breaks for an unknown amount of people who have been assuming that their driver will always work when modprobe'd, even though they are completely unaware of its new firmware needs All these are cases in use today. Real users, Linus. Real distros. Jeff P.S. And as I stated in another email, I'm happy to help fix this regression. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/