Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757968AbYGOSbR (ORCPT ); Tue, 15 Jul 2008 14:31:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754402AbYGOSbF (ORCPT ); Tue, 15 Jul 2008 14:31:05 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:46566 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754063AbYGOSbD (ORCPT ); Tue, 15 Jul 2008 14:31:03 -0400 Subject: Re: [GIT *] Allow request_firmware() to be satisfied from in-kernel, use it in more drivers. From: David Woodhouse To: Linus Torvalds Cc: Jeff Garzik , david@lang.hm, Arjan van de Ven , Andrew Morton , alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org In-Reply-To: References: <1216077806.27455.85.camel@shinybook.infradead.org> <20080714164119.99c33d5b.akpm@linux-foundation.org> <20080714165956.7fe2d4ee@infradead.org> <487C585C.2060002@garzik.org> <487CD7FE.9010209@garzik.org> <487CDEC0.3090004@garzik.org> <487CEA73.9000408@garzik.org> Content-Type: text/plain Date: Tue, 15 Jul 2008 11:30:51 -0700 Message-Id: <1216146651.27455.336.camel@shinybook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1692 Lines: 42 On Tue, 2008-07-15 at 11:25 -0700, Linus Torvalds wrote: > > On Tue, 15 Jul 2008, Jeff Garzik wrote: > > > > Which is why 'make modules_install' installs the firmware, or at least it did > > before David W pushed upstream. > > So you're literally just about making this be "make modules_install" > rather than "make firmware_install" > > Ok. Are you going to be happy if "make modules_install" just copies the > firmware files of the affected modules too? I did that already. I'm not _entirely_ sure it was the right thing to do, but it does help to reduce surprises when people don't realise that a driver they're using now has separate firmware. I don't believe it was the result of a constructive request from Jeff; I think someone else suggested it in response to his whining. It may even have been my idea, but I don't recall. This is the current situation: 'make modules_install' will install the firmware required by the modules it installs. It'll install that to $(INSTALL_MOD_PATH)/lib/firmware/ unless you override that by setting $(INSTALL_FW_PATH). So you can put it into a kernel-specific directory if you want to. 'make firmware_install' will install _all_ available firmware files to /lib/firmware (or $(INSTALL_FW_PATH)), regardless of architecture or configuration. That's what Fedora is using for its 'kernel-firmware' package, which is arch-independent and required by the various kernel binary packages. -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/