Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761642AbYGOSzr (ORCPT ); Tue, 15 Jul 2008 14:55:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755798AbYGOSzj (ORCPT ); Tue, 15 Jul 2008 14:55:39 -0400 Received: from mx1.redhat.com ([66.187.233.31]:48077 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755781AbYGOSzi (ORCPT ); Tue, 15 Jul 2008 14:55:38 -0400 Message-ID: <487CF206.4010905@redhat.com> Date: Tue, 15 Jul 2008 14:52:54 -0400 From: Masami Hiramatsu User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Peter Zijlstra CC: Mathieu Desnoyers , akpm@linux-foundation.org, Ingo Molnar , linux-kernel@vger.kernel.org, "Frank Ch. Eigler" , Hideo AOKI , Takashi Nishiie , Steven Rostedt , Alexander Viro , Eduard - Gabriel Munteanu , Paul E McKenney Subject: Re: [patch 01/15] Kernel Tracepoints References: <20080709145929.352201601@polymtl.ca> <20080709150043.693920317@polymtl.ca> <1216108237.12595.122.camel@twins> <20080715132543.GB20037@Krystal> <1216130593.12595.189.camel@twins> <20080715144628.GD20037@Krystal> <1216134829.12595.207.camel@twins> In-Reply-To: <1216134829.12595.207.camel@twins> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1206 Lines: 38 Hi, Peter Zijlstra wrote: > On Tue, 2008-07-15 at 10:46 -0400, Mathieu Desnoyers wrote: > >> Talking about headers, I have noticed that placing headers with the code >> may not be as clean as I would hope. For instance, the kernel/irq-trace.h >> header, when included from kernel/irq/handle.c, has to be included with: >> >> #include "../irq-trace.h" >> >> Which is not _that_ bad, but we we want to instrument the irq handler >> found in arch/x86/kernel/cpu/mcheck/mce_intel_64.c, including >> #include "../../../../../kernel/irq-trace.h" makes me go "yeeeek!" >> >> How about creating include/trace/irq.h and friends ? > > Might as well.. anybody else got opinions? I just wonder why DEFINE_TRACE are used in separated headers instead of include/linux/irq.h directly. anyway, #include is good to me. -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division e-mail: mhiramat@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/