Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762058AbYGOUAl (ORCPT ); Tue, 15 Jul 2008 16:00:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756932AbYGOUAP (ORCPT ); Tue, 15 Jul 2008 16:00:15 -0400 Received: from senator.holtmann.net ([87.106.208.187]:43042 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756651AbYGOUAN (ORCPT ); Tue, 15 Jul 2008 16:00:13 -0400 Subject: Re: [GIT *] Allow request_firmware() to be satisfied from in-kernel, use it in more drivers. From: Marcel Holtmann To: David Woodhouse Cc: Linus Torvalds , Jeff Garzik , david@lang.hm, Arjan van de Ven , Andrew Morton , alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org In-Reply-To: <1216146651.27455.336.camel@shinybook.infradead.org> References: <1216077806.27455.85.camel@shinybook.infradead.org> <20080714164119.99c33d5b.akpm@linux-foundation.org> <20080714165956.7fe2d4ee@infradead.org> <487C585C.2060002@garzik.org> <487CD7FE.9010209@garzik.org> <487CDEC0.3090004@garzik.org> <487CEA73.9000408@garzik.org> <1216146651.27455.336.camel@shinybook.infradead.org> Content-Type: text/plain Date: Tue, 15 Jul 2008 22:00:21 +0200 Message-Id: <1216152021.27242.94.camel@violet.holtmann.net> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2028 Lines: 50 Hi David, > > > Which is why 'make modules_install' installs the firmware, or at least it did > > > before David W pushed upstream. > > > > So you're literally just about making this be "make modules_install" > > rather than "make firmware_install" > > > > Ok. Are you going to be happy if "make modules_install" just copies the > > firmware files of the affected modules too? > > I did that already. I'm not _entirely_ sure it was the right thing to > do, but it does help to reduce surprises when people don't realise that > a driver they're using now has separate firmware. > > I don't believe it was the result of a constructive request from Jeff; I > think someone else suggested it in response to his whining. It may even > have been my idea, but I don't recall. > > This is the current situation: > > 'make modules_install' will install the firmware required by the modules > it installs. It'll install that to $(INSTALL_MOD_PATH)/lib/firmware/ > unless you override that by setting $(INSTALL_FW_PATH). So you can put > it into a kernel-specific directory if you want to. > > 'make firmware_install' will install _all_ available firmware files > to /lib/firmware (or $(INSTALL_FW_PATH)), regardless of architecture or > configuration. That's what Fedora is using for its 'kernel-firmware' > package, which is arch-independent and required by the various kernel > binary packages. I really think we should use /lib/firmware/`uname -r`/. I do see the point here that I don't wanna overwrite existing firmware from other installed kernels. Especially if modules_install will install the firmware files. So in case of non-Ubuntu distros we have to push a fix to udev, but that is not a big deal. It should be a one-line change if I am not mistaken. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/