Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758432AbYGOUdk (ORCPT ); Tue, 15 Jul 2008 16:33:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759211AbYGOUdY (ORCPT ); Tue, 15 Jul 2008 16:33:24 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:38749 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761946AbYGOUdX (ORCPT ); Tue, 15 Jul 2008 16:33:23 -0400 Message-ID: <487D0985.6080102@garzik.org> Date: Tue, 15 Jul 2008 16:33:09 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Marcel Holtmann CC: Linus Torvalds , David Woodhouse , Frans Pop , arjan@infradead.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org Subject: Re: [GIT *] Allow request_firmware() to be satisfied from in-kernel, use it in more drivers. References: <1216077806.27455.85.camel@shinybook.infradead.org> <20080714164119.99c33d5b.akpm@linux-foundation.org> <20080714165956.7fe2d4ee@infradead.org> <487C0365.5030203@garzik.org> <487C0365.5030203@garzik.org> <200807151757.10626.elendil@planet.nl> <1216149637.27242.65.camel@violet.holtmann.net> <1216150616.27455.377.camel@shinybook.infradead.org> <1216151640.27242.90.camel@violet.holtmann.net> <1216153270.27242.110.camel@violet.holtmann.net> In-Reply-To: <1216153270.27242.110.camel@violet.holtmann.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1178 Lines: 33 Marcel Holtmann wrote: > I really don't see that problem here since request_firmware() has been > around for so long now and so many drivers are using it nowadays that I > don't see your point here on how it will break. There is no fundamental breakage in the new request_firmware() system. However, it is misleading to state what I'm doing here is nothing new. Most modern drivers use request_firmware() already. because we are not talking about new drivers, we are talking about existing drivers changing en masse from "not requiring firmware" state to "requiring firmware" state. We are also talking about a totally new source of critically important data (the firmware, coming from the kernel tree), and scripts must be updated to take that into account. Sure, in many cases the fix may even be a one-liner... but you still need that fix, in order to continue to use drivers that were working in 2.6.26. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/