Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757651AbYGPFmp (ORCPT ); Wed, 16 Jul 2008 01:42:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751133AbYGPFmc (ORCPT ); Wed, 16 Jul 2008 01:42:32 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:52344 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbYGPFma (ORCPT ); Wed, 16 Jul 2008 01:42:30 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Tejun Heo Cc: Greg KH , Andrew Morton , Daniel Lezcano , linux-kernel@vger.kernel.org, Al Viro , Linux Containers , Benjamin Thery , netdev@vger.kernel.org References: <486DD650.3000804@gmail.com> <486E2C3B.6020603@gmail.com> <20080704161200.GA1440@suse.de> <487D6A24.9070001@gmail.com> Date: Tue, 15 Jul 2008 22:41:14 -0700 In-Reply-To: <487D6A24.9070001@gmail.com> (Tejun Heo's message of "Wed, 16 Jul 2008 12:25:24 +0900") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SA-Exim-Connect-IP: 24.130.11.59 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-DCC: XMission; sa01 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Tejun Heo X-Spam-Relay-Country: X-Spam-Report: * -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -1.1 BAYES_05 BODY: Bayesian spam probability is 1 to 5% * [score: 0.0195] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa01 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 XM_SPF_Neutral SPF-Neutral Subject: Re: [PATCH 12/15] driver core: Implement tagged directory support for device classes. X-SA-Exim-Version: 4.2 (built Thu, 03 Mar 2005 10:44:12 +0100) X-SA-Exim-Scanned: Yes (on mgr1.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1141 Lines: 25 Tejun Heo writes: > Greg, please disregard my earlier NACKs and commit the patches if you're > okay with them. I'm working on cleaning it up but I don't think I'll be > able to make it in time for merge window and as Eric said getting the > functionality in place is more important at this point as it doesn't > affect user visible interface. > > Eric, with the multiple superblocks, sysfs now uses inode from the > default sysfs_sb with dentries from other sb's. Is this okay? Are > there any other filesystems which do this? I don't know of any other filesystems where this unique challenge arises. /proc almost qualifies but it never needs to be modified. It is certainly ok to go from multiple dentries to a single inode. I'm trying to remember why I choose to do that. I think both because it simplifies the locking and keeps us more efficient in the icache. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/