Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759316AbYGPKLk (ORCPT ); Wed, 16 Jul 2008 06:11:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755936AbYGPKLc (ORCPT ); Wed, 16 Jul 2008 06:11:32 -0400 Received: from gw.goop.org ([64.81.55.164]:55515 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755927AbYGPKLb (ORCPT ); Wed, 16 Jul 2008 06:11:31 -0400 Message-ID: <487DC943.5060202@goop.org> Date: Wed, 16 Jul 2008 03:11:15 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Hidetoshi Seto CC: linux-kernel@vger.kernel.org, Rusty Russell , Heiko Carstens , Christian Borntraeger , virtualization@lists.linux-foundation.org, Zachary Amsden , Max Krasnyansky Subject: Re: [PATCH] stopmachine: add stopmachine_timeout v2 References: <487B05CE.1050508@jp.fujitsu.com> <487D78A3.6050105@jp.fujitsu.com> In-Reply-To: <487D78A3.6050105@jp.fujitsu.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 448 Lines: 16 Hidetoshi Seto wrote: > +#ifdef CONFIG_STOP_MACHINE > +extern unsigned long stopmachine_timeout; > +#endif > No externs in C files. Put it in an appropriate header. I'll do a proper review soon. J -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/