Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758270AbYGPPo0 (ORCPT ); Wed, 16 Jul 2008 11:44:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756505AbYGPPoQ (ORCPT ); Wed, 16 Jul 2008 11:44:16 -0400 Received: from smtp-out003.kontent.com ([81.88.40.217]:52321 "EHLO smtp-out003.kontent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756135AbYGPPoP (ORCPT ); Wed, 16 Jul 2008 11:44:15 -0400 From: Oliver Neukum Organization: NOvell To: Julia Lawall Subject: Re: [PATCH] drivers/usb/class/usblp.c: adjust error handling code Date: Wed, 16 Jul 2008 17:44:58 +0200 User-Agent: KMail/1.9.9 Cc: zaitcev@redhat.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807161744.59137.oliver@neukum.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 657 Lines: 19 Am Mittwoch 16 Juli 2008 17:17:42 schrieb Julia Lawall: > From: Julia Lawall > > In this code, it is possible to tell statically whether usblp will be NULL > in the error handling code. > > Another option would have been to put a label directly on the return. That would be better. It means less chance to overlook an error case if locking needs to be added in the future. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/