Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759239AbYGPW0q (ORCPT ); Wed, 16 Jul 2008 18:26:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757430AbYGPW0h (ORCPT ); Wed, 16 Jul 2008 18:26:37 -0400 Received: from mx1.redhat.com ([66.187.233.31]:49025 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757618AbYGPW0h (ORCPT ); Wed, 16 Jul 2008 18:26:37 -0400 Date: Wed, 16 Jul 2008 18:19:49 -0400 From: Dave Jones To: Kumar Gala Cc: Scott Wood , linuxppc-dev@ozlabs.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET Message-ID: <20080716221949.GA18148@redhat.com> Mail-Followup-To: Dave Jones , Kumar Gala , Scott Wood , linuxppc-dev@ozlabs.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org References: <20080716214722.GA6251@ld0162-tx32.am.freescale.net> <20080716215745.GA17093@redhat.com> <37829F82-D71C-4B42-A752-DA86C6F2764D@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37829F82-D71C-4B42-A752-DA86C6F2764D@kernel.crashing.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1361 Lines: 36 On Wed, Jul 16, 2008 at 05:10:29PM -0500, Kumar Gala wrote: > > On Jul 16, 2008, at 4:57 PM, Dave Jones wrote: > > > On Wed, Jul 16, 2008 at 04:47:23PM -0500, Scott Wood wrote: > >> On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote: > >>> If we don't enable FS_ENET we get build issues: > >>> > >>> arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe': > >>> arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to > >>> `alloc_mdio_bitbang' > >>> arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to > >>> `mdiobus_register' > >> > >> How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG. > > > > If CONFIG_PHYLIB=m however, that doesn't make any difference, because > > vmlinuz is trying to use a symbol which now lives in a module. > > The mdiobus_register make sense, I'm not sure get why > alloc_mdio_bitbang is undefined. Erm, same reason. it's built into phy.o, which ends up in the module, not the vmlinuz. (also, it doesn't look like it's exported even if it was built-in?) Dave -- http://www.codemonkey.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/