Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760203AbYGPXLd (ORCPT ); Wed, 16 Jul 2008 19:11:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759587AbYGPXLG (ORCPT ); Wed, 16 Jul 2008 19:11:06 -0400 Received: from gate.crashing.org ([63.228.1.57]:53704 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759011AbYGPXLF (ORCPT ); Wed, 16 Jul 2008 19:11:05 -0400 Date: Wed, 16 Jul 2008 18:05:58 -0500 (CDT) From: Kumar Gala X-X-Sender: galak@blarg.am.freescale.net To: linuxppc-dev@ozlabs.org cc: davej@redhat.com, Benjamin Herrenschmidt , akpm@linux-foundation.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH] powerpc/ep8248e: Unconditionally select PHYLIB for mdio_bitbang Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1488 Lines: 46 Its possible to build the phylib as a module, however this breaks the board code because alloc_mdio_bitbang and mdiobus_register are not available if we build as a module. These are needed by the board code since it implements the low level mdio bitbang ops. So we unconditionally select PHYLIB to ensure its built into the kernel if we are building in EP8248E support. Long term we should look at moving the mdio_ops into its own file so it can be built as a module. Signed-off-by: Kumar Gala --- This patch supercededs: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET I've reverted the old patch and applied the new patch in my git tree and have asked Ben to pull and push it to Linus. - k arch/powerpc/platforms/82xx/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/platforms/82xx/Kconfig b/arch/powerpc/platforms/82xx/Kconfig index 1c8034b..75eb1ed 100644 --- a/arch/powerpc/platforms/82xx/Kconfig +++ b/arch/powerpc/platforms/82xx/Kconfig @@ -30,6 +30,7 @@ config EP8248E select 8272 select 8260 select FSL_SOC + select PHYLIB select MDIO_BITBANG help This enables support for the Embedded Planet EP8248E board. -- 1.5.5.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/