Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754708AbYGQCrj (ORCPT ); Wed, 16 Jul 2008 22:47:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754494AbYGQCrM (ORCPT ); Wed, 16 Jul 2008 22:47:12 -0400 Received: from 175.212.dsnet ([203.110.175.212]:18613 "EHLO mail.atheros.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754105AbYGQCrK convert rfc822-to-8bit (ORCPT ); Wed, 16 Jul 2008 22:47:10 -0400 From: Jie Yang To: Roland Dreier CC: Stephen Hemminger , "jeff@garzik.org" , David Miller , "jcliburn@gmail.com" , "parag.warudkar@gmail.com" , Willy Tarreau , "oliver.schuster@schweigstill.de" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Thu, 17 Jul 2008 10:47:07 +0800 Subject: RE: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver Thread-Topic: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver Thread-Index: AcjnYhx46xq8jE6vRzy+18o9cqca+QAVAGQQ Message-ID: <72981EBCFD196144B7C6999B9FC34A9A3EE613106D@SHEXMB-01.global.atheros.com> References: <72981EBCFD196144B7C6999B9FC34A9A3EE60E9F58@SHEXMB-01.global.atheros.com> <20080715211514.25848d8a@extreme> <72981EBCFD196144B7C6999B9FC34A9A3EE60EA59C@SHEXMB-01.global.atheros.com> <20080716085329.03e97b2a@extreme> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: zh-CN, en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1187 Lines: 35 On Thursday, July 17, 2008 12:36 AM Roland Dreier wrote: > > > Output of checkpatch (scripts/checkpatch.pl in kernel source). > > Personally, I am not a whitespace bigot, and don't think > > all the warnings in checkpatch have to be fixed. > > > > ---------- > > ERROR: patch seems to be corrupt (line wrapped?) > #121: > FILE: drivers/net/atl1e/atl1e.h:9: > > ree > > > > WARNING: space prohibited between function name and open > parenthesis '(' > > #212: FILE: drivers/net/atl1e/atl1e.h:97: > > + _tpd =3D (((_vlan) << (4)) | (((_vlan) >> 13) & 7) |\ > > It's kind of pointless to run checkpatch on a corrupted patch > (the email was quoted-printable and you didn't decode it back > to text). Of course it's also better to send non-mangled patches. > > - R. > Hi, Roland I used outlook to send these patches, can you give me some aderise on how to send non-mangled patches. Best wishes jie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/