Date: Thu, 17 Jul 2008 09:34:26 -0400
From: Christoph Hellwig <hch@infradead.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Roland McGrath <roland@redhat.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org,
       hch@infradead.org
Subject: Re: [PATCH 01/23] tracehook: add linux/tracehook.h
Message-ID: <20080717133426.GA9577@infradead.org>
References: <20080717072541.F390E15411D@magilla.localdomain> <20080717072755.E2FBC15411D@magilla.localdomain> <20080717084818.GA5637@martell.zuzino.mipt.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080717084818.GA5637@martell.zuzino.mipt.ru>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 804
Lines: 20

On Thu, Jul 17, 2008 at 12:48:18PM +0400, Alexey Dobriyan wrote:
> > The new linux/ptrace.h inlines are used by the following patches in the
> > new tracehook_*() inlines.  Using these helpers for the ptrace event
> > stops makes it simple to change or disable the old ptrace implementation
> > of these stops conditionally later.
> 
> Call them "utrace_*" from the start?

Yes, please.

> Pointless 1:1 wrapper unless you're going to #ifdef ->ptrace later.

Even then I don't think it's a good idea.  This one should only be
touched in very very few places

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/