Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758824AbYGQONr (ORCPT ); Thu, 17 Jul 2008 10:13:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757684AbYGQONi (ORCPT ); Thu, 17 Jul 2008 10:13:38 -0400 Received: from rtsoft3.corbina.net ([85.21.88.6]:9533 "EHLO buildserver.ru.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1757491AbYGQONh (ORCPT ); Thu, 17 Jul 2008 10:13:37 -0400 Date: Thu, 17 Jul 2008 18:13:35 +0400 From: Anton Vorontsov To: Grant Likely Cc: Trent Piepho , Richard Purdie , Stephen Rothwell , Kumar Gala , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH v3] leds: implement OpenFirmare GPIO LED driver Message-ID: <20080717141335.GA2219@polina.dev.rtsoft.ru> Reply-To: avorontsov@ru.mvista.com References: <1216133032.5345.73.camel@dax.rpnet.com> <20080715151917.GA30607@polina.dev.rtsoft.ru> <20080717041531.GA27243@secretlab.ca> <20080717140519.GA32617@polina.dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Disposition: inline In-Reply-To: <20080717140519.GA32617@polina.dev.rtsoft.ru> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 23 On Thu, Jul 17, 2008 at 06:05:19PM +0400, Anton Vorontsov wrote: [...] > > I think it would be better to have a module that scans the device tree > > for LED nodes and registers a single leds-gpio platform device for the > > whole lot. > > > > Thoughts? > > I like the idea, thanks. Ugh, no. The idea sounds good, but in practice it isn't, since we'll have to handle suspend/resume ops ourselves. When we stick with the device/driver model we're getting all this for free. -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/