Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758189AbYGQORv (ORCPT ); Thu, 17 Jul 2008 10:17:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756583AbYGQORm (ORCPT ); Thu, 17 Jul 2008 10:17:42 -0400 Received: from mx1.redhat.com ([66.187.233.31]:43376 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756253AbYGQORl (ORCPT ); Thu, 17 Jul 2008 10:17:41 -0400 Date: Thu, 17 Jul 2008 09:57:46 -0400 From: Josef Bacik To: Vegard Nossum Cc: Josef Bacik , linux-ext4@vger.kernel.org, sct@redhat.com, akpm@linux-foundation.org, adilger@sun.com, Johannes Weiner , linux-kernel@vger.kernel.org Subject: Re: ext3 on latest -git: BUG: unable to handle kernel NULL pointer dereference at 0000000c Message-ID: <20080717135746.GB14133@unused.rdu.redhat.com> References: <19f34abd0807170551q4fbb862bu270297cfd76a69be@mail.gmail.com> <1b7401870807170613y747baa7by158177047cc7e28@mail.gmail.com> <19f34abd0807170620g39ab942bl592ea3fa3fa0dab@mail.gmail.com> <1b7401870807170634u14492a53k3931ddcddbd1e098@mail.gmail.com> <19f34abd0807170639p838d14blc9a13d2104313f38@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19f34abd0807170639p838d14blc9a13d2104313f38@mail.gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2403 Lines: 81 On Thu, Jul 17, 2008 at 03:39:24PM +0200, Vegard Nossum wrote: > On Thu, Jul 17, 2008 at 3:34 PM, Josef Bacik wrote: > >> Yeah, the full log exists at > >> > >> http://folk.uio.no/vegardno/linux/log-1216293934.txt > >> > >> I think this is the interesting part: > > > > Hmm well the journal should have aborted, but it looks like it didn't, > > are you mounting with errors=continue by any chance? Thanks much, > > No, this is the command I used: > > mount -o loop disk mnt > > I think this looks interesting: > > EXT3-fs error (device loop0) in ext3_reserve_inode_write: IO failure > > The code in ext3_reserve_inode_write() is here: > > err = ext3_journal_get_write_access(handle, iloc->bh); > if (err) { > brelse(iloc->bh); > iloc->bh = NULL; > } > > Maybe it should do something different here? > > But I don't know :-) > > Thanks for helping out! > > Can you try this patch out and see if it fixes the problem? I didn't compile test it, so you may need to tweak somethings, but it should work. Thanks, Signed-off-by: Josef Bacik Index: linux-2.6/fs/ext3/inode.c =================================================================== --- linux-2.6.orig/fs/ext3/inode.c +++ linux-2.6/fs/ext3/inode.c @@ -2023,13 +2023,27 @@ static void ext3_clear_blocks(handle_t * unsigned long count, __le32 *first, __le32 *last) { __le32 *p; + int ret; + if (try_to_extend_transaction(handle, inode)) { if (bh) { BUFFER_TRACE(bh, "call ext3_journal_dirty_metadata"); - ext3_journal_dirty_metadata(handle, bh); + ret = ext3_journal_dirty_metadata(handle, bh); + if (ret) { + ext3_std_error(inode->i_sb, ret); + return; + } } - ext3_mark_inode_dirty(handle, inode); - ext3_journal_test_restart(handle, inode); + ret = ext3_mark_inode_dirty(handle, inode); + if (ret) + return; + + ret = ext3_journal_test_restart(handle, inode); + if (ret) { + ext3_std_error(inode->i_sb, ret); + return; + } + if (bh) { BUFFER_TRACE(bh, "retaking write access"); ext3_journal_get_write_access(handle, bh); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/