Subject: Re: [PATCH] systemtap: fix up on_each_cpu() for kernels 2.6.26+
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: systemtap@sourceware.org
Cc: linux-kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <1216313476.5515.16.camel@localhost.localdomain>
References: <1216313476.5515.16.camel@localhost.localdomain>
Content-Type: text/plain
Date: Thu, 17 Jul 2008 11:53:11 -0500
Message-Id: <1216313591.5515.19.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1048
Lines: 29

On Thu, 2008-07-17 at 11:51 -0500, James Bottomley wrote:
> In kernel 2.6.26, this patch
> 
> commit 15c8b6c1aaaf1c4edd67e2f02e4d8e1bd1a51c0d
> Author: Jens Axboe <jens.axboe@oracle.com>
> Date:   Fri May 9 09:39:44 2008 +0200
> 
>     on_each_cpu(): kill unused 'retry' parameter
> 
> means that runtime/time.c is now using the wrong calling conventions.
> Fix this up and surround it by kernel versioning #ifdefs.

By the way, this is a classic illustration of the fragility problem in
holding the systemtap runtime outside of the kernel.  If it had been
in-kernel, all this would be fixed up and running and no-one would even
have noticed.

At least with changes in argument numbers, the compile breaks ... it
would have been a lot nastier if one of the variables simply changed
meaning ...

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/