Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760657AbYGQSus (ORCPT ); Thu, 17 Jul 2008 14:50:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758087AbYGQSuj (ORCPT ); Thu, 17 Jul 2008 14:50:39 -0400 Received: from out3.smtp.messagingengine.com ([66.111.4.27]:55371 "EHLO out3.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756218AbYGQSui (ORCPT ); Thu, 17 Jul 2008 14:50:38 -0400 X-Sasl-enc: KQV1Tb/Qpspy6TB4TipPO9035VTU2g6jX3WyQDqHruY4 1216320636 Date: Thu, 17 Jul 2008 15:50:32 -0300 From: Henrique de Moraes Holschuh To: Alan Jenkins Cc: Alexey Starikovskiy , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC Message-ID: <20080717185032.GD18457@khazad-dum.debian.net> References: <487D23C3.5070301@student.cs.york.ac.uk> <487F31D7.30803@suse.de> <20080717121309.GF31732@khazad-dum.debian.net> <487F3B6D.3090507@suse.de> <20080717162628.GB18457@khazad-dum.debian.net> <487F7724.5080905@tuffmail.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <487F7724.5080905@tuffmail.co.uk> X-GPG-Fingerprint: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1205 Lines: 24 On Thu, 17 Jul 2008, Alan Jenkins wrote: > Actually Alexey has another patch in bugzilla (#10919) which resolves > this issue in a better way. It avoids polling altogether, which is good > because it means you get events immediately. My laptop has backlight > adjustment hotkeys with hardware autorepeat, so it looks really jerky > with polling. We need to get ALL pending events from the EC, whether in polling mode or in interrupt mode (and we must make sure that we ARE going to queue any new interrupt before we stop checking for an empty pending event queue, otherwise there is a small window where a new event might get queued, and we are still masking the GPE and don't notice it). As long as the fix does that, it is all I care :-) -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/