Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932717AbYGQWbT (ORCPT ); Thu, 17 Jul 2008 18:31:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755120AbYGQWbG (ORCPT ); Thu, 17 Jul 2008 18:31:06 -0400 Received: from rgminet01.oracle.com ([148.87.113.118]:22795 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753981AbYGQWbE (ORCPT ); Thu, 17 Jul 2008 18:31:04 -0400 Date: Thu, 17 Jul 2008 15:30:18 -0700 From: Joel Becker To: Linus Torvalds , Mark Fasheh , linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, Andrew Morton Subject: Re: [Ocfs2-devel] [git patches] Ocfs2 and Configfs updates for 2.6.27 Message-ID: <20080717223018.GC8283@ca-server1.us.oracle.com> Mail-Followup-To: Linus Torvalds , Mark Fasheh , linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, Andrew Morton References: <20080717175146.GH28014@wotan.suse.de> <20080717212038.GA8283@ca-server1.us.oracle.com> <20080717214512.GB8283@ca-server1.us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080717214512.GB8283@ca-server1.us.oracle.com> X-Burt-Line: Trees are cool. X-Red-Smith: Ninety feet between bases is perhaps as close as man has ever come to perfection. User-Agent: Mutt/1.5.16 (2007-06-11) X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1257 Lines: 38 On Thu, Jul 17, 2008 at 02:45:12PM -0700, Joel Becker wrote: > On Thu, Jul 17, 2008 at 02:20:38PM -0700, Joel Becker wrote: > > On Thu, Jul 17, 2008 at 11:01:40AM -0700, Linus Torvalds wrote: > > > I pulled it, but I want to register my protest. > > > > I wish you hadn't, because it won't be to difficult to go back > > to PTR_ERR(). However, don't revert it - that affects some of the > > follow-on patches that were affected by the change. > > I lied. I'll cleanup the fallout. You can revert it or wait > for my revert + PTR_ERR. Let me know if you revert it. Linus, Pull this to get the revert and the PTR_ERR() version: git://oss.oracle.com/git/jlbec/linux-2.6.git configfs-fixup-ptr-error It's tested with the same testing I did before - ocfs2 and netconsole. Joel -- "But all my words come back to me In shades of mediocrity. Like emptiness in harmony I need someone to comfort me." Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/