Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754400AbYGRIF2 (ORCPT ); Fri, 18 Jul 2008 04:05:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751882AbYGRIFB (ORCPT ); Fri, 18 Jul 2008 04:05:01 -0400 Received: from aeryn.fluff.org.uk ([87.194.8.8]:50904 "EHLO kira.home.fluff.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751468AbYGRIE7 (ORCPT ); Fri, 18 Jul 2008 04:04:59 -0400 Date: Fri, 18 Jul 2008 09:04:57 +0100 From: Ben Dooks To: Magnus Damm Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, gregkh@suse.de, lethal@linux-sh.org, i2c@lm-sensors.org, akpm@linux-foundation.org Subject: Re: [PATCH 04/05] i2c-sh_mobile: IORESOURCE_CLK support Message-ID: <20080718080457.GM24620@fluff.org.uk> References: <20080718074002.32713.73442.sendpatchset@rx1.opensource.se> <20080718074036.32713.92629.sendpatchset@rx1.opensource.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080718074036.32713.92629.sendpatchset@rx1.opensource.se> X-Disclaimer: These are my own opinions, so there! User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1976 Lines: 55 On Fri, Jul 18, 2008 at 04:40:36PM +0900, Magnus Damm wrote: > From: Magnus Damm > > This patch makes the i2c-sh_mobile driver get the clock name from the > struct resource with type IORESOURCE_CLK provided by the platform data. > > Signed-off-by: Magnus Damm > --- > > drivers/i2c/busses/i2c-sh_mobile.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > --- 0001/drivers/i2c/busses/i2c-sh_mobile.c > +++ work/drivers/i2c/busses/i2c-sh_mobile.c 2008-07-18 14:56:40.000000000 +0900 > @@ -390,13 +390,19 @@ static int sh_mobile_i2c_probe(struct pl > int size; > int ret; > > + res = platform_get_resource(dev, IORESOURCE_CLK, 0); > + if (res == NULL || res->name == NULL) { > + dev_err(&dev->dev, "cannot find CLK resource\n"); > + return -ENOENT; > + } > + > pd = kzalloc(sizeof(struct sh_mobile_i2c_data), GFP_KERNEL); > if (pd == NULL) { > dev_err(&dev->dev, "cannot allocate private data\n"); > return -ENOMEM; > } > > - pd->clk = clk_get(&dev->dev, "peripheral_clk"); I think that is working correctly and there isn't really any need to change this. The clk_get is supplied the device that it needs the clock for, and the name of the clock needed. > + pd->clk = clk_get(&dev->dev, res->name); > if (IS_ERR(pd->clk)) { > dev_err(&dev->dev, "cannot get peripheral clock\n"); > ret = PTR_ERR(pd->clk); > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Ben (ben@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/