Message-ID: <416379761.08031@ustc.edu.cn>
From: "JiSheng Zhang" <jszhang3@mail.ustc.edu.cn>
To: stefanr@s5r6.in-berlin.de
Cc: linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net,
       krh@redhat.com
Date: Fri, 18 Jul 2008 19:16:00 +0800
Reply-To: "JiSheng Zhang" <jszhang3@mail.ustc.edu.cn>
Subject: Re: PATCH] firewire: add padding to some struct
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1898
Lines: 55

Hi,
If p is a pointer to struct fw_cdev_event_response), p->data will point to the
padding data rather than the right place, it will cause problem under some
platforms. For example, in the function handle_device_event of libraw1394(ported
to juju stack):
.....
case FW_CDEV_EVENT_RESPONSE:
    rc = u64_to_ptr(u->response.closure);
    if (rc->data != NULL)
	memcpy(rc->data, u->response.data, rc->length);//here it will lost the last four
bytes
    errcode = juju_to_raw1394_errcode(u->response.rcode);
.....

Although this problem can be solved by add the offset to the pointer, but the
member:__u32 data[0] lost its original meaning.

Thanks in advance,
JiSheng
>From: Stefan Richter <stefanr@s5r6.in-berlin.de>
>Reply-To: 
>To: JiSheng Zhang <jszhang3@mail.ustc.edu.cn>
>Subject: Re: PATCH] firewire: add padding to some struct
>Date:Fri, 18 Jul 2008 12:49:11 +0200
>
>JiSheng Zhang wrote:
> > struct fw_cdev_event_response and struct fw_cdev_event_iso_interrupt need
padding.
> > Otherwise, offset of the zero length array is not equal to the struct size. It
may
> > cause some strange problems under some platforms such as sparc32. This
> > patch(against 2.6.26) should fix it.
> 
> The best solution to this problem would be to use
> 
> 	offsetof(struct fw_cdev_event_XYZ, data)
> 
> instead of sizeof(struct fw_cdev_event_XYZ) in all the places where the
> offset is required.
> 
> Your proposed solution to add padding...
> 
> > --- old/include/linux/firewire-cdev.h	2008-07-18 16:34:01.181794046 +0800
> > +++ new/include/linux/firewire-cdev.h	2008-07-18 16:35:46.649294275 +0800
> > @@ -92,6 +92,7 @@
> >  	__u32 type;
> >  	__u32 rcode;
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/