Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759251AbYGRMeT (ORCPT ); Fri, 18 Jul 2008 08:34:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756715AbYGRMeK (ORCPT ); Fri, 18 Jul 2008 08:34:10 -0400 Received: from smtpq1.groni1.gr.home.nl ([213.51.130.200]:58777 "EHLO smtpq1.groni1.gr.home.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756482AbYGRMeK (ORCPT ); Fri, 18 Jul 2008 08:34:10 -0400 Message-ID: <48808E39.4060404@keyaccess.nl> Date: Fri, 18 Jul 2008 14:36:09 +0200 From: Rene Herman User-Agent: Thunderbird 2.0.0.14 (X11/20080421) MIME-Version: 1.0 To: Krzysztof Helt CC: Takashi Iwai , Ingo Molnar , Jaroslav Kysela , LKML , ALSA development , "Rafael J. Wysocki" , Rene Herman , Krzysztof Helt Subject: Re: [boot crash, bisected] in 9f240a55 "ALSA: opti93x: use cs4231 lib" References: <20080717170657.GA14593@elte.hu> <487F9B9B.2010905@keyaccess.nl> <487F9FA1.7020101@keyaccess.nl> <48806017.1040307@keyaccess.nl> <20080718142849.f11ce4c8.krzysztof.h1@poczta.fm> In-Reply-To: <20080718142849.f11ce4c8.krzysztof.h1@poczta.fm> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.0 (-) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1740 Lines: 45 On 18-07-08 14:28, Krzysztof Helt wrote: > On Fri, 18 Jul 2008 11:19:19 +0200 > Rene Herman wrote: > >> On 17-07-08 21:38, Rene Herman wrote: >> >>> On 17-07-08 21:20, Rene Herman wrote: >>> >>>> On 17-07-08 20:40, Takashi Iwai wrote: >>>> >>>>> Could you try the patch below? >> This bug was uncovered by !CONFIG_PNP and we had trouble in this driver >> due to that before so was rewriting the init to be a generic multi-card >> ALSA init but, actually, not much point. >> > > The bug was introduced by the patch as it used (tried to free) the codec pointer > before it was assigned any value. It happened only if the card was missing and > I didn't test the driver on such a configuration. My mistake. The CONFIG_PNP > setting makes no difference. Yes it does. Note how the ISA match method fails due to "if (isapnp)" with CONFIG_PNP and isapnp being initialized to 1. I did test without the hardware but didn't see it fail due to that. >> In fact, in the meantime I'll look at splitting 92x and 93x again. It's >> much better now that Krzysztof made it use the generic library code but >> I still hate this driver. It's also poking at ports without being told >> something is there by either system or user. >> > > Please hold your axe until Monday. The last patch (not posted yet) from the > unification of the WSS library series removes some ifdefs in this driver. > This may (or may not) change your view on splitting the driver. Will do. Rene. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/