Message-ID: <4880A9D0.3060300@goop.org>
Date: Fri, 18 Jul 2008 07:33:52 -0700
From: Jeremy Fitzhardinge <jeremy@goop.org>
User-Agent: Thunderbird 2.0.0.14 (X11/20080501)
MIME-Version: 1.0
To: Dhaval Giani <dhaval@linux.vnet.ibm.com>
CC: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
       lkml <linux-kernel@vger.kernel.org>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: Current git fails to compile
References: <20080718075340.GC16453@linux.vnet.ibm.com> <20080718091441.GR6875@elte.hu> <20080718134126.GA30416@linux.vnet.ibm.com>
In-Reply-To: <20080718134126.GA30416@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1089
Lines: 24

Dhaval Giani wrote:
>     This patch also pulls the pmd preallocation and mop-up functions out
>     to be common, assuming that the compiler will generate no code for
>     them when PREALLOCTED_PMDS is 0.

Well, there's nothing particularly special in that code.  The only 
slightly complex requirement on the compiler is that it notice that a 
0-iteration for loop is a do-nothing, and that it eliminate the code.  
And that's not really a requirement, it's just nice to have.

The fact that your compiler is warning about an unused variable in an 
unused function suggests that it isn't doing this (I'm assuming your 
config has CONFIG_X86_PAE=n).  But there are no inline asms or other 
things which traditionally cause compilers to fall over.

So, I'm not really sure what to do about this.  Any chance of using a 
newer compiler?

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/