Date: Fri, 18 Jul 2008 15:12:28 -0400
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] nfs: nfs4xdr use C99 array initializers
Message-ID: <20080718191228.GD12007@fieldses.org>
References: <1216355583.6029.137.camel@brick> <20080718180115.GJ8035@fieldses.org> <1216404127.6029.149.camel@brick>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1216404127.6029.149.camel@brick>
User-Agent: Mutt/1.5.18 (2008-05-17)
From: "J. Bruce Fields" <bfields@fieldses.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1292
Lines: 31

On Fri, Jul 18, 2008 at 11:02:07AM -0700, Harvey Harrison wrote:
> On Fri, 2008-07-18 at 14:01 -0400, J. Bruce Fields wrote:
> > On Thu, Jul 17, 2008 at 09:33:03PM -0700, Harvey Harrison wrote:
> > > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > 
> > OK, thanks.  But I'd rather just skip the macro:
> > 
> > > +#define NFSD4_DEC_OP(idx, op)	[(idx)] = (nfsd4_dec)(op)
> > > -	[OP_ACCESS]		(nfsd4_dec)nfsd4_decode_access,
> > > -	[OP_CLOSE]		(nfsd4_dec)nfsd4_decode_close,
> > > -	[OP_COMMIT]		(nfsd4_dec)nfsd4_decode_commit,
> > > -	[OP_CREATE]		(nfsd4_dec)nfsd4_decode_create,
> > > -	[OP_DELEGPURGE]		(nfsd4_dec)nfsd4_decode_notsupp,
> > ...
> > > +	NFSD4_DEC_OP(OP_ACCESS, nfsd4_decode_access),
> > > +	NFSD4_DEC_OP(OP_CLOSE, nfsd4_decode_close),
> > > +	NFSD4_DEC_OP(OP_COMMIT, nfsd4_decode_commit),
> > > +	NFSD4_DEC_OP(OP_CREATE, nfsd4_decode_create),
> > > +	NFSD4_DEC_OP(OP_DELEGPURGE, nfsd4_decode_notsupp),
> > 
> > and just add equals signs, if there's no substantial objection.
> > 
> 
> None here.

Thanks, done.--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/