Subject: Re: [patch 1/3] fastboot: Create a "asynchronous" initlevel
From: Daniel Walker <dwalker@mvista.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu
In-Reply-To: <20080718151608.46dc17c0@infradead.org>
References: <20080718151524.5ef9e29b@infradead.org>
	 <20080718151608.46dc17c0@infradead.org>
Content-Type: text/plain
Date: Fri, 18 Jul 2008 18:22:20 -0700
Message-Id: <1216430540.3978.137.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 916
Lines: 24

On Fri, 2008-07-18 at 15:16 -0700, Arjan van de Ven wrote:
> +static void __init do_initcalls(void)
> +{
> +       initcall_t *call;
> +       static DECLARE_WORK(async_work, do_async_initcalls);
> +       int phase = 0; /* 0 = levels 0 - 6, 1 = level 6a, 2 = after
> level 6a */
> +
> +       async_init_wq = create_singlethread_workqueue("kasyncinit");
> +

Could you spawning one thread per cpu, and queuing the work evenly?
Maybe that's what your work towards. The "6a" level might be pretty
short, but there are some other levels that can get pretty large with
calls that would benefit from this.. There are a lot of calls that
already spawn threads too ..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/