Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757904AbYGSBbS (ORCPT ); Fri, 18 Jul 2008 21:31:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753554AbYGSBa7 (ORCPT ); Fri, 18 Jul 2008 21:30:59 -0400 Received: from server.drzeus.cx ([85.8.24.28]:37287 "EHLO smtp.drzeus.cx" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751670AbYGSBa5 (ORCPT ); Fri, 18 Jul 2008 21:30:57 -0400 Date: Sat, 19 Jul 2008 03:30:50 +0200 From: Pierre Ossman To: Tejun Heo Cc: "Rafael J. Wysocki" , James Bottomley , Stephen Rothwell , linux-next@vger.kernel.org, LKML , Andrew Morton , Kernel Testers List , scsi , Jens Axboe , linux-ide , Jeff Garzik , Takashi Iwai , tino.keitel@gmx.de Subject: Re: linux-next: Tree for July 16 (crash on quad core AMD) Message-ID: <20080719033050.552f9b49@mjolnir.drzeus.cx> In-Reply-To: <48813C5F.70007@gmail.com> References: <20080716235011.ac9643aa.sfr@canb.auug.org.au> <200807170053.36661.rjw@sisk.pl> <1216249292.3358.66.camel@localhost.localdomain> <200807170109.30655.rjw@sisk.pl> <48808EE0.2060603@gmail.com> <20080719004736.626ef169@mjolnir.drzeus.cx> <48813C5F.70007@gmail.com> X-Mailer: Claws Mail 3.4.0 (GTK+ 2.13.4; i386-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAMAAABg3Am1AAAAAXNSR0IArs4c6QAAADNQTFRFEgwFRSofeTwxZEI1h1lFl1ZHeGBetHZk24VzuZJ43p2GsbKw/Lmg2MTL/NO3/+/Q//fpWFujUwAAAk5JREFUSMeNlVcWnDAMRd0bLux/tVGxiAEzic7hZ+Zd1IU6NtbYdn8daic/cgj52CPqLQ8hOBdjzsD8G2hHsCiPBS2/nTyABi93zvsYUyql1v6KSz30AeUAJLAK1uuDUI94WA7GDsAePtRDfwFRgP7DA8vvwOgQ1R5oYQUKAwOsfwDHDcAcWH+e5xagiooey1SwSAy0L8C7BaDKdgKWoNQtIjYEfHQGzMcKwNgCpLdgBn14ZzXNSPkJWK201vjiHMkXZg7AuQWCA7G2DPTiMSIsLSZxbgEIwlqEjE+9WBu0yaWOHwDLLQE9WmMieCBgtG1IAFgBzo7tlojGtbI3wFljuU4JdL3ghPeO+tFr2QHG0DOBSuN0kofaU302zmKbcTrgAWDUywG0OvXELi6gZScAdq6WnhYgvYDGu0YQjYSZs3ROID0B4y+jjpWyAhjePWkAjKwD5o09xioNBoro/+YQZjzTg8ce1CJtwFvwAMDFBEjv6cgI0P/u0DqtGJOjNSAm4e0jABxsgDYXSADQw2wwsFyzdePCAviE48QexseKNiGcp4jgKNEVAGC7QEwY5+S6Qpf50NzujHrdYgEKH0o8ZJ/AQR8HAGiaugDjG2i4ddZx4wToPwB0gQsEfjyFRKf1M+kLQC8u5iuoX8BhxYCQJPZXQ7LQdDnQR87/BdCpQQSJpREh7EMSQOvpYwJaqbAHgrUXkWehxhmUUjpsQ+IDSHlzEvidywrtDYSpnHVioNbstBLi9o3Dn/WqZ3Nw1pUQy8bN3/QdiPiVUZfpP4cDVEKd2cXEAAAAAElFTkSuQmCC X-Face: @{|$W51qEixc&6}dq_38NM^&.vv|'{O)ae?DMZ1%VYxuhN2}5VpQ!'gx[{V+8Xw'+cV5*491_)-SU2YT8s@4`H;@:ELS'/P(@.JxxJi/C8mG0H#A^R X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2343 Lines: 63 This is a MIME-formatted message. If you see this text it means that your E-mail software does not support MIME-formatted messages. --=_freyr.drzeus.cx-25412-1216431055-0001-2 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 19 Jul 2008 09:59:11 +0900 Tejun Heo wrote: > Pierre Ossman wrote: > > I just have one objection to your version, and that is that it cannot > > be used to nibble away at the sg list. The _next() call jumps an entire > > page, whereas you sometimes need to consume that page in two different > > sweeps. This could be handled by some external buffer that keeps the > > remainder of the page, but the point of these functions was to keep > > things simple for the callers. >=20 > Well, I don't know how often such usages would be necessary. If it's a > very common ops, you can add a param to the next function but frankly I > think it's better to build a inside control structure for that. There's > no need for external buffer, just an inner loop is sufficient. >=20 I'm not sure how this can be solved by an inner loop. My primary use case is: 1. Wait for interrupt 2. Write n bytes 3. goto 1 n has no guarantee of being aligned to any page boundaries, so state needs to be kept between each invokation of writing a chunk of data. I doubt I'm alone in this use pattern (in fact, most device drivers using PIO should do something similar). --=20 -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption. --=_freyr.drzeus.cx-25412-1216431055-0001-2 Content-Type: application/pgp-signature; name="signature.asc" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAkiBQ84ACgkQ7b8eESbyJLh53QCg7qnc+iwa36yyuiN8TlQ4A9Yj 0WQAoLHgjuev75S9ngB8lO9/0neIaAvZ =Oe++ -----END PGP SIGNATURE----- --=_freyr.drzeus.cx-25412-1216431055-0001-2-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/