Message-ID: <487B3DA1.7010906@kernel.org>
Date: Mon, 14 Jul 2008 20:50:57 +0900
From: Tejun Heo <tj@kernel.org>
User-Agent: Thunderbird 2.0.0.12 (X11/20071114)
MIME-Version: 1.0
To: Cornelia Huck <cornelia.huck@de.ibm.com>
CC: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Jens Axboe <jens.axboe@oracle.com>, Greg K-H <greg@kroah.com>
Subject: Re: [PATCH] block: fix block_class iteration locking
References: <487AECD0.5010602@kernel.org> <20080714134228.1079c6f7@gondolin.boeblingen.de.ibm.com>
In-Reply-To: <20080714134228.1079c6f7@gondolin.boeblingen.de.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1017
Lines: 26

Cornelia Huck wrote:
> Greg has some patches sitting in his tree that convert those functions
> to use class_{for_each,find}_device() instead - and that looks like the
> clean solution, especially since the class implementation details will
> be moved into a private structure. One worry though...

Yeah, that sounds nice.

> With your patch, you protect against adding/removing devices to/from
> the class between _start and _stop. This wasn't done previously, and
> won't be done with Greg's patches (which leaves in the
> locking/unlocking of block_class_lock). Not sure if I'm missing
> something here...

That's mostly the point of this patch.  It wasn't protected properly
before.  It would be best if there's a safe iterator (maybe use klist?).

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/