Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756004AbYGSRYm (ORCPT ); Sat, 19 Jul 2008 13:24:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754118AbYGSRYe (ORCPT ); Sat, 19 Jul 2008 13:24:34 -0400 Received: from mail.parknet.ad.jp ([210.171.162.6]:47246 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989AbYGSRYe (ORCPT ); Sat, 19 Jul 2008 13:24:34 -0400 From: OGAWA Hirofumi To: Yoshinori Sato Cc: Andrew Morton , lkml Subject: Re: [PATCH] filldir write data missing size References: <87k5fi4l49.wl%ysato@users.sourceforge.jp> Date: Sun, 20 Jul 2008 02:24:28 +0900 In-Reply-To: <87k5fi4l49.wl%ysato@users.sourceforge.jp> (Yoshinori Sato's message of "Fri, 18 Jul 2008 23:18:46 -0400") Message-ID: <871w1pn5wz.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Anti-Virus: Kaspersky Anti-Virus for MailServers 5.5.10/RELEASE, bases: 24052007 #308098, status: clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 974 Lines: 30 Yoshinori Sato writes: > "loff_t" is long long. > But "d_off" is unsigned long. > > Signed-off-by: Yoshinori Sato > > diff --git a/fs/readdir.c b/fs/readdir.c > index 4e026e5..01e7152 > --- a/fs/readdir.c > +++ b/fs/readdir.c > @@ -159,7 +159,7 @@ static int filldir(void * __buf, const char * name, int namlen, loff_t offset, > return -EOVERFLOW; > dirent = buf->previous; > if (dirent) { > - if (__put_user(offset, &dirent->d_off)) > + if (__put_user((unsigned long)offset, &dirent->d_off)) Um.. __put_user() should be already doing it automatically.. > goto efault; > } > dirent = buf->current_dir; -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/