Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756315AbYGSRsP (ORCPT ); Sat, 19 Jul 2008 13:48:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754553AbYGSRsA (ORCPT ); Sat, 19 Jul 2008 13:48:00 -0400 Received: from mail.parknet.ad.jp ([210.171.162.6]:57435 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754338AbYGSRsA (ORCPT ); Sat, 19 Jul 2008 13:48:00 -0400 From: OGAWA Hirofumi To: Pekka J Enberg Cc: linux-kernel@vger.kernel.org, cl@linux-foundation.org, akpm@linux-foundation.org, riel@redhat.com Subject: Re: [PATCH 2/8] slub: Replace ctor field with ops field in /sys/slab/* References: <87tzellqf9.fsf@devron.myhome.or.jp> Date: Sun, 20 Jul 2008 02:47:56 +0900 In-Reply-To: <87tzellqf9.fsf@devron.myhome.or.jp> (OGAWA Hirofumi's message of "Sun, 20 Jul 2008 02:44:26 +0900") Message-ID: <87prp9lq9f.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Anti-Virus: Kaspersky Anti-Virus for MailServers 5.5.10/RELEASE, bases: 24052007 #308098, status: clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 24 OGAWA Hirofumi writes: > Pekka J Enberg writes: > >> + if (s->ctor) { >> + x += sprintf(buf + x, "ctor : "); >> + x += sprint_symbol(buf + x, (unsigned long)s->ctor); >> + x += sprintf(buf + x, "\n"); > > How about new "%pS" like following for it? If CONFIG_KALLSYMS=n, it has > difference though... > > x += sprintf(buf + x, "ctor : %pS\n", (unsigned long)s->ctor); Oops, it should be pointer. x += sprintf(buf + x, "ctor : %pS\n", s->ctor); -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/