Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756332AbYGSS2S (ORCPT ); Sat, 19 Jul 2008 14:28:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753064AbYGSS2H (ORCPT ); Sat, 19 Jul 2008 14:28:07 -0400 Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.123]:40213 "EHLO cdptpa-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752547AbYGSS2G (ORCPT ); Sat, 19 Jul 2008 14:28:06 -0400 Date: Sat, 19 Jul 2008 14:28:06 -0400 Message-ID: <87iqv1wwy1.wl%ysato@users.sourceforge.jp> From: Yoshinori Sato To: OGAWA Hirofumi Cc: Andrew Morton , lkml Subject: Re: [PATCH] filldir write data missing size In-Reply-To: <871w1pn5wz.fsf@devron.myhome.or.jp> References: <87k5fi4l49.wl%ysato@users.sourceforge.jp> <871w1pn5wz.fsf@devron.myhome.or.jp> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.7 Emacs/22.2 (x86_64-pc-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1223 Lines: 43 At Sun, 20 Jul 2008 02:24:28 +0900, OGAWA Hirofumi wrote: > > Yoshinori Sato writes: > > > "loff_t" is long long. > > But "d_off" is unsigned long. > > > > Signed-off-by: Yoshinori Sato > > > > diff --git a/fs/readdir.c b/fs/readdir.c > > index 4e026e5..01e7152 > > --- a/fs/readdir.c > > +++ b/fs/readdir.c > > @@ -159,7 +159,7 @@ static int filldir(void * __buf, const char * name, int namlen, loff_t offset, > > return -EOVERFLOW; > > dirent = buf->previous; > > if (dirent) { > > - if (__put_user(offset, &dirent->d_off)) > > + if (__put_user((unsigned long)offset, &dirent->d_off)) > > Um.. __put_user() should be already doing it automatically.. I'm mistake. I checked object, and found bad code. This problem fix __put_user. Thanks. > > goto efault; > > } > > dirent = buf->current_dir; > -- > OGAWA Hirofumi -- Yoshinori Sato -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/