Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756409AbYGTDUZ (ORCPT ); Sat, 19 Jul 2008 23:20:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755247AbYGTDUL (ORCPT ); Sat, 19 Jul 2008 23:20:11 -0400 Received: from mx1.redhat.com ([66.187.233.31]:58519 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754947AbYGTDUK (ORCPT ); Sat, 19 Jul 2008 23:20:10 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Oleg Nesterov X-Fcc: ~/Mail/linus Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] coredump: kill mm->core_done In-Reply-To: Oleg Nesterov's message of Tuesday, 15 July 2008 18:07:15 +0400 <20080715140715.GA25824@tv-sign.ru> References: <20080715140715.GA25824@tv-sign.ru> Emacs: ed :: 20-megaton hydrogen bomb : firecracker Message-Id: <20080720032001.E707315421D@magilla.localdomain> Date: Sat, 19 Jul 2008 20:20:01 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 685 Lines: 15 It is indeed ugly. I think the place to start is with moving all the coredump code out of exit_mm() into a new subfunction that is just passed the mm pointer, and doing the same with coredump_finish() as you've done, but leaving the completion logic inside those functions the same. If all references to the core_* fields in mm_struct are inside coredump_*() functions, then that is a good basis for the future cleanups. Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/