MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: Roland McGrath <roland@redhat.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 23/23] /proc/PID/syscall
In-Reply-To: Alexey Dobriyan's message of  Friday, 18 July 2008 02:56:32 +0400 <20080717225632.GA16887@martell.zuzino.mipt.ru>
References: <20080717072541.F390E15411D@magilla.localdomain>
	<20080717073144.5A28715411D@magilla.localdomain>
	<20080717225632.GA16887@martell.zuzino.mipt.ru>
Message-Id: <20080721081925.B666515421D@magilla.localdomain>
Date: Mon, 21 Jul 2008 01:19:25 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 616
Lines: 15

> My gut feeling this code needs ptrace_may_access() checks.

That would be fine with me.  The nodes are readable only by user, which
seems sufficient to me.  But I certainly don't object to the stronger check
there.  I didn't put too much thought into /proc/pid/syscall, it's just
there to demonstrate and test the internal task_current_syscall() call.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/