Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753978AbYGUQZY (ORCPT ); Mon, 21 Jul 2008 12:25:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752164AbYGUQZL (ORCPT ); Mon, 21 Jul 2008 12:25:11 -0400 Received: from sj-iport-5.cisco.com ([171.68.10.87]:25206 "EHLO sj-iport-5.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751967AbYGUQZJ (ORCPT ); Mon, 21 Jul 2008 12:25:09 -0400 X-IronPort-AV: E=Sophos;i="4.31,224,1215388800"; d="scan'208";a="37948307" From: Roland Dreier To: Julia Lawall Cc: rolandd@cisco.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, general@lists.openfabrics.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, hnguyen@de.ibm.com, raisch@de.ibm.com Subject: Re: [PATCH 1/7] drivers/infiniband: Release mutex in error handling code References: X-Message-Flag: Warning: May contain useful information Date: Mon, 21 Jul 2008 09:25:07 -0700 In-Reply-To: (Julia Lawall's message of "Mon, 21 Jul 2008 09:57:04 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OriginalArrivalTime: 21 Jul 2008 16:25:08.0213 (UTC) FILETIME=[5725CA50:01C8EB4E] Authentication-Results: sj-dkim-4; header.From=rdreier@cisco.com; dkim=pass ( sig from cisco.com/sjdkim4002 verified; ); Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 712 Lines: 20 > --- a/drivers/infiniband/hw/ehca/ipz_pt_fn.c > +++ b/drivers/infiniband/hw/ehca/ipz_pt_fn.c > @@ -163,6 +163,7 @@ static int alloc_small_queue_page(struct > > out: > ehca_err(pd->ib_pd.device, "failed to allocate small queue page"); > + mutex_unlock(&pd->lock); > return 0; > } Thanks, looks obviously correct. ehca guys, I will queue this for my next pull request to Linus; please let me know if you see a problem and want me to drop it. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/