Message-ID: <4884F9A4.8060201@goop.org>
Date: Mon, 21 Jul 2008 14:03:32 -0700
From: Jeremy Fitzhardinge <jeremy@goop.org>
User-Agent: Thunderbird 2.0.0.14 (X11/20080501)
MIME-Version: 1.0
To: Adrian Bunk <bunk@kernel.org>
CC: Christian Limpach <Christian.Limpach@xensource.com>,
       Jens Axboe <jens.axboe@oracle.com>, xen-devel@lists.xensource.com,
       linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] xen-blkfront.c: make blkif_ioctl() static
References: <20080721193339.GC14846@cs181140183.pp.htv.fi>
In-Reply-To: <20080721193339.GC14846@cs181140183.pp.htv.fi>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1112
Lines: 33

Adrian Bunk wrote:
> This patch makes the needlessly global blkif_ioctl() static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>   
Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>

> ---
> c3e35790145bb28443ccb672fb46318e845c5f05 
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 9ae05c5..3ca643c 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -154,8 +154,8 @@ static int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
>  	return 0;
>  }
>  
> -int blkif_ioctl(struct inode *inode, struct file *filep,
> -		unsigned command, unsigned long argument)
> +static int blkif_ioctl(struct inode *inode, struct file *filep,
> +		       unsigned command, unsigned long argument)
>  {
>  	struct blkfront_info *info =
>  		inode->i_bdev->bd_disk->private_data;
>
>   


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/