Message-ID: <4884FF00.30101@s5r6.in-berlin.de>
Date: Mon, 21 Jul 2008 23:26:24 +0200
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.15) Gecko/20080719 SeaMonkey/1.1.10
MIME-Version: 1.0
To: David Miller <davem@davemloft.net>
CC: torvalds@linux-foundation.org, mingo@elte.hu, akpm@linux-foundation.org,
       netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [crash] kernel BUG at net/core/dev.c:1328!
References: <alpine.LFD.1.10.0807211131390.31863@woody.linux-foundation.org>	<20080721.120052.123606398.davem@davemloft.net>	<4884E174.5030802@s5r6.in-berlin.de> <20080721.131129.244101157.davem@davemloft.net>
In-Reply-To: <20080721.131129.244101157.davem@davemloft.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1085
Lines: 32

David Miller wrote:
> You should only do a netif_stop_queue() in your device
> initialization, at the very end of ->open() processing
> when you've fully committed to returning success.
> 
> You should not, in particular, be doing a netif_wake_queue()
> before you've even done a netif_start_queue().
> 
> Many of these drivers are using netif_{stop,wake}_queue()
> to stop packet flow, in particular when link state changes,
> and netif_carrier_{on,off}() already does all of that for
> you.
> 
> Really, anything outside of:
> 
> 1) netif_start_queue() in ->open()
> 2) netif_stop_queue() in ->stop()
> 3) netif_{stop,wake}_queue() in the TX packet handling path
> 
> is superfluous.

Thanks, I wasn't aware of this.  I'll try to fix up eth1394 this way as 
time permits.
-- 
Stefan Richter
-=====-==--- -=== =-=-=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/