Date: Tue, 22 Jul 2008 12:45:26 +0400
From: Oleg Nesterov <oleg@tv-sign.ru>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, akinobu.mita@gmail.com
Subject: Re: + workqueue-proper-error-unwinding-in-cpu-hotplug-error-path.patch added to -mm tree
Message-ID: <20080722084526.GA165@tv-sign.ru>
References: <200807220826.m6M8Q4I6018588@imap1.linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200807220826.m6M8Q4I6018588@imap1.linux-foundation.org>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1108
Lines: 35

On 07/22, Andrew Morton wrote:
> 
> From: Akinobu Mita <akinobu.mita@gmail.com>
> 
> Add proper error unwinding in error path in CPU_UP_PREPARE notifier.

Could you clarify?

> --- a/kernel/workqueue.c~workqueue-proper-error-unwinding-in-cpu-hotplug-error-path
> +++ a/kernel/workqueue.c
> @@ -928,6 +928,15 @@ static int __devinit workqueue_cpu_callb
>  				break;
>  			printk(KERN_ERR "workqueue [%s] for %i failed\n",
>  				wq->name, cpu);
> +
> +			list_for_each_entry_continue_reverse(wq, &workqueues,
> +							list) {
> +				cwq = per_cpu_ptr(wq->cpu_wq, cpu);
> +				start_workqueue_thread(cwq, -1);
> +				cleanup_workqueue_thread(cwq);
> +			}
> +			cpu_clear(cpu, cpu_populated_map);
> +
>  			return NOTIFY_BAD;

If CPU_UP_PREPARE fails, _cpu_up() sends CPU_UP_CANCELED, and afaics
workqueue_cpu_callback() correctly cleanups cwq->thread's.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/