Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754388AbYGVKF1 (ORCPT ); Tue, 22 Jul 2008 06:05:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752593AbYGVKFQ (ORCPT ); Tue, 22 Jul 2008 06:05:16 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:57021 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751935AbYGVKFO (ORCPT ); Tue, 22 Jul 2008 06:05:14 -0400 Date: Tue, 22 Jul 2008 03:05:06 -0700 From: Andrew Morton To: Matthew Wilcox Cc: Linus Torvalds , Peter Anvin , "David S. Miller" , linux-ia64@vger.kernel.org, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH] Make u64 long long on all architectures (was: the printk problem) Message-Id: <20080722030506.206a2cc2.akpm@linux-foundation.org> In-Reply-To: <20080705020350.GN14894@parisc-linux.org> References: <20080625131101.GA6205@digi.com> <20080704104634.GA31634@digi.com> <20080704111540.ddffd241.akpm@linux-foundation.org> <20080704132716.f1e12554.akpm@linux-foundation.org> <20080704204252.GM14894@parisc-linux.org> <20080704150100.1f7b8a65.akpm@linux-foundation.org> <20080705020350.GN14894@parisc-linux.org> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1639 Lines: 44 On Fri, 4 Jul 2008 20:03:51 -0600 Matthew Wilcox wrote: > [PATCH] Make u64 long long on all architectures > > It is currently awkward to print a u64 type. Some architectures use > unsigned long while others use unsigned long long. Since unsigned long > long is 64-bit for all existing Linux architectures, change those that > use long to use long long. Note that this applies only within the > kernel. If u64 is being used in a C++ method definition, the symbol > mangling would change. > > Signed-off-by: Matthew Wilcox > > diff --git a/include/asm-generic/int-l64.h b/include/asm-generic/int-l64.h > index 2af9b75..32f07bd 100644 > --- a/include/asm-generic/int-l64.h > +++ b/include/asm-generic/int-l64.h > @@ -23,8 +23,13 @@ typedef unsigned short __u16; > typedef __signed__ int __s32; > typedef unsigned int __u32; > > +#ifdef __KERNEL__ > +typedef __signed__ long long __s64; > +typedef unsigned long long __u64; > +#else > typedef __signed__ long __s64; > typedef unsigned long __u64; > +#endif > > #endif /* __ASSEMBLY__ */ This is (IMO) a desirable change and will prevent a heck of a lot of goofing around, and will permit a lot of prior goofing around to be removed. But I bet there are lots of instalces of printk("%l", some_u64) down in arch code where the type of u64 _is_ known which will now spew warnings. Oh well. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/